Fix a number of small issues in rmw_zenoh_cpp #106
Merged
+49
−186
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a smorgasbord of small fixes around the tree. It is probably easiest to look at the individual patches, but in short:
get_nodes_names
for large graphs, since we don't have to iterate over the namespaces anymore.rcutils_strdup
implementations. The original reason for that hand-coding is gone, so we can just usercutils_strdup
now.ros_topic_name_to_zenoh_key
. In particular,std::to_string
is much faster thanstd::stringstream
, so use that.z_drop
the sample.rmw_compare_gids_equal
, which just gets us one step closer to having a complete implementation.